Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploaded .json settings bug fixups #1082

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Uploaded .json settings bug fixups #1082

merged 2 commits into from
Dec 29, 2023

Conversation

gerth2
Copy link
Contributor

@gerth2 gerth2 commented Dec 29, 2023

Resolved race condition between saveGlobal and saveOneFile modifying settings on shutdown. Previously, saveGlobal would overwrite the action of saveOneFile on a clean shutdown.

@gerth2 gerth2 requested a review from a team as a code owner December 29, 2023 02:50
mcm001
mcm001 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fits -> ships

@mcm001 mcm001 merged commit ef039da into PhotonVision:master Dec 29, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerth2 @mcm001